crashmedia/Arctic-Wolves-Production
1
0
Fork 0
Code Issues Pull requests 5 Projects Releases Packages Wiki Activity Actions

fix: widen blue/center lines +6px, extend goal lines to boards #8

Open
crashmedia wants to merge 5 commits from fix/rink-drawing-issues into main
pull from: fix/rink-drawing-issues
merge into: crashmedia:main
Conversation 1 Commits 5 Files changed 3 +99 -174
crashmedia commented 2026-06-14 05:18:21 +00:00
Owner
Copy link

Changes

Issue 1: Widen blue lines and center red line by 6 pixels

  • js/ice_canvas.js: Changed lineWidth = 2 to Math.round(h / 85) + 6 for blue lines and center red line in all 4 drawing functions (drawFullIce, drawZone, drawCenterIce, drawHalfIceLengthwise)
  • js/drill_designer.js: Changed lineWidth = Math.round(h / 85) to Math.round(h / 85) + 6 for blue lines and center red line in all 4 drawing functions
  • generate_rink_images.php: Changed imagesetthickness($img, 14) to imagesetthickness($img, 20) for center red line and blue lines

Issue 2: Extend goal lines to boards

  • js/ice_canvas.js: Removed cornerRadius clipping in drawFullIce, drawZone, and drawHalfIceLengthwise — goal lines now extend from 0 to full height
  • js/drill_designer.js: Same changes — removed cornerRadius clipping in drawFullIce and drawZone
  • generate_rink_images.php: Already correct — getGoalLineYBounds() returns the full straight board section

Issue 3: L-brackets verified ✅

  • All 3 files already match the cross pattern (N/S/E/W cardinal positions with inward-pointing arms)

Cleanup

  • Removed orphaned cornerRadius variables from goal line clipping logic
## Changes ### Issue 1: Widen blue lines and center red line by 6 pixels - `js/ice_canvas.js`: Changed `lineWidth = 2` to `Math.round(h / 85) + 6` for blue lines and center red line in all 4 drawing functions (`drawFullIce`, `drawZone`, `drawCenterIce`, `drawHalfIceLengthwise`) - `js/drill_designer.js`: Changed `lineWidth = Math.round(h / 85)` to `Math.round(h / 85) + 6` for blue lines and center red line in all 4 drawing functions - `generate_rink_images.php`: Changed `imagesetthickness($img, 14)` to `imagesetthickness($img, 20)` for center red line and blue lines ### Issue 2: Extend goal lines to boards - `js/ice_canvas.js`: Removed cornerRadius clipping in `drawFullIce`, `drawZone`, and `drawHalfIceLengthwise` — goal lines now extend from 0 to full height - `js/drill_designer.js`: Same changes — removed cornerRadius clipping in `drawFullIce` and `drawZone` - `generate_rink_images.php`: Already correct — `getGoalLineYBounds()` returns the full straight board section ### Issue 3: L-brackets verified ✅ - All 3 files already match the cross pattern (N/S/E/W cardinal positions with inward-pointing arms) ### Cleanup - Removed orphaned `cornerRadius` variables from goal line clipping logic
crashmedia commented 2026-06-14 05:18:48 +00:00
Author
Owner
Copy link

Updated with all 4 fixes

All changes committed to fix/rink-drawing-issues branch:

  1. NZ dots: Moved from 70ft to 80ft from end boards (inside blue line toward center)
  2. Hash marks: Shortened to 3ft (was 4ft), spacing increased to 2.5ft (was 2ft)
  3. Goal line: Already clipped correctly — fixed by corner radius change
  4. Corner radius: Corrected to 28ft NHL spec (was 12ft)

Test preview uploaded to PWA screenshots repo: ice-rink-full-preview.png

## Updated with all 4 fixes All changes committed to `fix/rink-drawing-issues` branch: 1. **NZ dots**: Moved from 70ft to 80ft from end boards (inside blue line toward center) 2. **Hash marks**: Shortened to 3ft (was 4ft), spacing increased to 2.5ft (was 2ft) 3. **Goal line**: Already clipped correctly — fixed by corner radius change 4. **Corner radius**: Corrected to 28ft NHL spec (was 12ft) Test preview uploaded to PWA screenshots repo: `ice-rink-full-preview.png`
crashmedia changed title from Fix rink drawing: corner radius, NZ dots, hash marks to fix: widen blue/center lines +6px, extend goal lines to boards 2026-06-22 20:28:51 +00:00
This pull request has changes conflicting with the target branch.
  • generate_rink_images.php
  • js/drill_designer.js
  • js/ice_canvas.js
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/rink-drawing-issues:fix/rink-drawing-issues
git switch fix/rink-drawing-issues

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix/rink-drawing-issues
git switch fix/rink-drawing-issues
git rebase main
git switch main
git merge --ff-only fix/rink-drawing-issues
git switch fix/rink-drawing-issues
git rebase main
git switch main
git merge --no-ff fix/rink-drawing-issues
git switch main
git merge --squash fix/rink-drawing-issues
git switch main
git merge --ff-only fix/rink-drawing-issues
git switch main
git merge fix/rink-drawing-issues
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
crashmedia/Arctic-Wolves-Production!8
No description provided.